Feat: support array type for datetime_ref in plot_age_pyramid()
#43
Conversation
…iffers for each patient: eg. the date of their inclusion in the study.
- add a new test for pytest.raise - add a parsable datetime string - add better error messages when bad value or bad type
Co-authored-by: Thomas Petit-Jean <30775613+Thomzoy@users.noreply.github.com>
Vincent-Maladiere
changed the title
datetime_ref in plot_age_pyramid()
eds_scikit/plot/data_quality.py
Outdated
|
|
||
| person_["age"] = deltas / (365 * 24 * 3600) | ||
| person_ = person_.query("age > 0.0") | ||
| mask = person_["age"] > 90 |
There was a problem hiding this comment.
Why this mask ?
Is it for privacy reason due to low samples with aged more than 90 ?
There was a problem hiding this comment.
I was mainly to gather rare categories (90, 100, 110) and avoid making too many bins with very few individuals. Does it seem relevant to you?
There was a problem hiding this comment.
It is relevant for me as I understand that this mask basically merge the bins: (90, 100], (100, 110], and above, which is the classic intention of a user.
|
I struggle with resolving the conversation but LGTM ! |
|
I need to add some documentation then we'll be good to merge :) |
|
I'm just waiting for #41 to be merged so that I can complete the documentation! |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 83.80% 83.84% +0.03%
==========================================
Files 82 82
Lines 2488 2494 +6
==========================================
+ Hits 2085 2091 +6
Misses 403 403
☔ View full report in Codecov by Sentry. |
|
@strayMat finally, it's merged :) |
|
So coole ! Thanks ! |
Description
Checklist